-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower.json has invalid JSON #66
Comments
flow check failing because of the error |
I don't know, but isn't /src/ used to build with? During build the version is changed. If you are not building, can't you use the build bower file in /dist ? I think you have to write more detailed of what you are doing. |
It causes problems when using Flow to statically analyze the source code. |
So how do you suggest that it is fixed? How do other Bower project handle this? |
From a brief test, it seems this could be fixed by renaming It's strange that Flow is checking this file at all since none of the sources require it. |
bower.json is the correct filename https://bower.io/docs/creating-packages/ |
Yes, but it doesn't have to be the name of the template that is used to create the output file. The current build script reads the contents from The output ( The output file should be the only one that needs to conform to Bower's standards. |
It would be great if you can make sure that |
I worked around this error by changing the value "version" to the value of version which is located in the node_modules/bcryptjs/bower.json file. Flow didn't show any errors at all after this. |
I worked around this by adding a
This script automatically runs after |
When I am running one of my projects through some CI tools, I am getting an error caused by this file. Is this something you guys can fix on your side? If not, I will try do a workaround or ignore. I am specifically using the Flow tool for type validation.
https://github.com/dcodeIO/bcrypt.js/blob/master/src/bower.json#L4
Thanks!
The text was updated successfully, but these errors were encountered: