Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcodeIO.bcrypt.setRandomFallback not in minified distribution build #55

Closed
drstearns opened this issue Jan 29, 2017 · 0 comments
Closed

Comments

@drstearns
Copy link

I'm used this fabulous library to build a quick hashing playground page for my students, but I ran into a little snag when I tried to call setRandomFallback() using the minified distribution build. I included bcrypt.min.js from your dist folder in my page, but trying to call this setRandomFallback() method generated a runtime error saying that the function didn't exist. I switched to the unminified bcrypt.js and everything ran fine without errors.

To be sure, I also did a console.log(dcodeIO.bcrypt) to see what was on the object, and when using the minified version, there was no setRandomFallback() method available. With the unminified version, there was.

I noticed that you said the minified version "has been compiled with Closure Compiler using advanced optimizations." Is it possible that those optimizations are stripping out this method since it's never called by your own code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant