Huge speedup! #53
Merged
Huge speedup! #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2017 17:37
…t this is because it packs the data tighter in RAM so it can fit in the CPU cache more easily.
… remove two `& 0xFF` instructions. This saves ~30ms on my machine (at cost 12).
|
Looks good, let me try! |
|
About 50% speedup for the test suite here. Pretty neat! |
|
Note: I did not commit new files in dist as I was unclear how you build those. You might want to adjust the 2.7x slower figure in the README and benchmark numbers on the wiki. This might also address issue #42 as I witnessed the disparity myself (before the Int32Array optimization). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're gonna like this. One big optimization and two small ones. See commit messages.